To be a good photographer you need both technical and artistic knowledge and skills.

Technical skills and knowledge.

Focus
Exposure
Aperture
Shutter Speed
ISO
Knowing your camera

Artistic skills and knowledge

Depth of field
Lenses
Light
Timing
Composition
Subject